netdev - Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200603143647.GC2274@nanopsycho.orion>
Date:   Wed, 3 Jun 2020 16:36:47 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vadym Kochan <vadym.kochan@...ision.eu>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Andrew Lunn <andrew@...n.ch>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        Serhiy Boiko <serhiy.boiko@...ision.eu>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Andrii Savka <andrii.savka@...ision.eu>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mickey Rachamim <mickeyr@...vell.com>
Subject: Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera
 family ASIC devices

Wed, Jun 03, 2020 at 04:29:44PM CEST, jiri@...nulli.us wrote:
>Thu, May 28, 2020 at 05:12:40PM CEST, vadym.kochan@...ision.eu wrote:
>
>[...]
>
>>+static int prestera_port_create(struct prestera_switch *sw, u32 id)
>>+{
>>+	struct prestera_port *port;
>>+	struct net_device *dev;
>>+	int err;
>>+
>>+	dev = alloc_etherdev(sizeof(*port));
>>+	if (!dev)
>>+		return -ENOMEM;
>>+
>>+	port = netdev_priv(dev);
>>+
>>+	port->dev = dev;
>>+	port->id = id;
>>+	port->sw = sw;
>>+
>>+	err = prestera_hw_port_info_get(port, &port->fp_id,
>>+					&port->hw_id, &port->dev_id);
>>+	if (err) {
>>+		dev_err(prestera_dev(sw), "Failed to get port(%u) info\n", id);
>>+		goto err_port_init;
>>+	}
>>+
>>+	dev->features |= NETIF_F_NETNS_LOCAL;
>>+	dev->netdev_ops = &netdev_ops;
>>+
>>+	netif_carrier_off(dev);
>
>No need.

Actually, it is. Sorry :)