netdev - Re: [Patch net] genetlink: fix memory leaks in genl_family_rcv_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpWfU0W1tn2zEPnCtWqDXD6gCmH0_5K_8kksmifjzN8cCQ@mail.gmail.com>
Date:   Tue, 2 Jun 2020 21:29:45 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Cc:     syzbot+21f04f481f449c8db840@...kaller.appspotmail.com,
        Florian Westphal <fw@...len.de>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jiri Pirko <jiri@...lanox.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Shaochun Chen <cscnull@...il.com>
Subject: Re: [Patch net] genetlink: fix memory leaks in genl_family_rcv_msg_dumpit()

On Tue, Jun 2, 2020 at 8:30 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>         if (ops->start) {
> -               genl_lock();
> +               if (!ctx->family->parallel_ops)
> +                       genl_lock();
>                 rc = ops->start(cb);
> -               genl_unlock();
> +               if (!ctx->family->parallel_ops)
> +                       genl_unlock();
>         }

Hmm, wg_get_device_start() uses cb->data, so I have to install it before this.

Will send v2.

Thanks.