netdev - Re: [PATCH 3/4] qat: use GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202006032110.kZE2Ah0d%lkp@intel.com>
Date:   Wed, 3 Jun 2020 21:43:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mikulas Patocka <mpatocka@...hat.com>,
        Mike Snitzer <msnitzer@...hat.com>,
        Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Milan Broz <mbroz@...hat.com>, djeffery@...hat.com
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        dm-devel@...hat.com, qat-linux@...el.com,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH 3/4] qat: use GFP_KERNEL allocations

Hi Mikulas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on cryptodev/master]
[also build test WARNING on crypto/master dm/for-next v5.7 next-20200603]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Mikulas-Patocka/Intel-QAT-fixes/20200602-001343
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-randconfig-s021-20200603 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-244-g0ee050a8-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/crypto/qat/qat_common/qat_algs.c:139:49: sparse: sparse: incorrect type in return expression (different base types) @@     expected int @@     got restricted gfp_t @@
>> drivers/crypto/qat/qat_common/qat_algs.c:139:49: sparse:     expected int
>> drivers/crypto/qat/qat_common/qat_algs.c:139:49: sparse:     got restricted gfp_t
>> drivers/crypto/qat/qat_common/qat_algs.c:728:33: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted gfp_t [usertype] flags @@     got int gfp @@
>> drivers/crypto/qat/qat_common/qat_algs.c:728:33: sparse:     expected restricted gfp_t [usertype] flags
>> drivers/crypto/qat/qat_common/qat_algs.c:728:33: sparse:     got int gfp
   drivers/crypto/qat/qat_common/qat_algs.c:762:48: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted gfp_t [usertype] flags @@     got int gfp @@
   drivers/crypto/qat/qat_common/qat_algs.c:762:48: sparse:     expected restricted gfp_t [usertype] flags
   drivers/crypto/qat/qat_common/qat_algs.c:762:48: sparse:     got int gfp
>> drivers/crypto/qat/qat_common/qat_algs.c:1072:69: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected restricted gfp_t [usertype] gfp @@     got int @@
>> drivers/crypto/qat/qat_common/qat_algs.c:1072:69: sparse:     expected restricted gfp_t [usertype] gfp
>> drivers/crypto/qat/qat_common/qat_algs.c:1072:69: sparse:     got int
   drivers/crypto/qat/qat_common/qat_algs.c:1131:69: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected restricted gfp_t [usertype] gfp @@     got int @@
   drivers/crypto/qat/qat_common/qat_algs.c:1131:69: sparse:     expected restricted gfp_t [usertype] gfp
   drivers/crypto/qat/qat_common/qat_algs.c:1131:69: sparse:     got int

vim +139 drivers/crypto/qat/qat_common/qat_algs.c

   136	
   137	static int qat_gfp(u32 flags)
   138	{
 > 139		return flags & CRYPTO_TFM_REQ_MAY_SLEEP ? GFP_KERNEL : GFP_ATOMIC;
   140	}
   141	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (38075 bytes)