netdev - Re: [PATCH] net: sched: make the watchdog functions more coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200604.155512.1355727491425437227.davem@davemloft.net>
Date:   Thu, 04 Jun 2020 15:55:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     valentin@...gchamp.me
Cc:     netdev@...r.kernel.org, jiri@...nulli.us, xiyou.wangcong@...il.com,
        jhs@...atatu.com
Subject: Re: [PATCH] net: sched: make the watchdog functions more coherent

From: Valentin Longchamp <valentin@...gchamp.me>
Date: Wed,  3 Jun 2020 23:21:13 +0200

> Remove dev_watchdog_up() that directly called __netdev_watchdog_up() and
> rename dev_watchdog_down() to __netdev_watchdog_down() for symmetry.
> 
> Signed-off-by: Valentin Longchamp <valentin@...gchamp.me>
> ---
>  net/sched/sch_generic.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index 2efd5b61acef..f3cb740a2941 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -465,12 +465,7 @@ void __netdev_watchdog_up(struct net_device *dev)
>  	}
>  }
>  
> -static void dev_watchdog_up(struct net_device *dev)
> -{
> -	__netdev_watchdog_up(dev);
> -}
> -
> -static void dev_watchdog_down(struct net_device *dev)
> +static void __netdev_watchdog_down(struct net_device *dev)

This patch will not apply if I apply your symbol export patch because
the context above this function will be different.

Please don't do this.