netdev - Re: [PATCH v2 3/7] Bluetooth: Add handler of MGMT_OP_ADD_ADV_PATTERNS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200603200621.52c24ee1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 3 Jun 2020 20:06:21 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Miao-chen Chou <mcchou@...omium.org>
Cc:     Bluetooth Kernel Mailing List <linux-bluetooth@...r.kernel.org>,
        Alain Michaud <alainm@...omium.org>,
        Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
        Manish Mandlik <mmandlik@...omium.org>,
        Michael Sun <michaelfsun@...gle.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Yoni Shavit <yshavit@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 3/7] Bluetooth: Add handler of
 MGMT_OP_ADD_ADV_PATTERNS_MONITOR

On Wed,  3 Jun 2020 16:01:46 -0700 Miao-chen Chou wrote:
> This adds the request handler of MGMT_OP_ADD_ADV_PATTERNS_MONITOR command.
> Note that the controller-based monitoring is not yet in place. This tracks
> the content of the monitor without sending HCI traffic, so the request
> returns immediately.
> 
> The following manual test was performed.
> - Issue btmgmt advmon-add with valid and invalid inputs.
> - Issue btmgmt advmon-add more the allowed number of monitors.
> 
> Signed-off-by: Miao-chen Chou <mcchou@...omium.org>

Looks like this adds new sparse warnings:

net/bluetooth/mgmt.c:3886:32: warning: incorrect type in assignment (different base types)
net/bluetooth/mgmt.c:3886:32:    expected unsigned int [usertype] supported_features
net/bluetooth/mgmt.c:3886:32:    got restricted __le32 [usertype]
net/bluetooth/mgmt.c:3888:29: warning: incorrect type in assignment (different base types)
net/bluetooth/mgmt.c:3888:29:    expected unsigned short [usertype] max_num_handles
net/bluetooth/mgmt.c:3888:29:    got restricted __le16 [usertype]
net/bluetooth/mgmt.c:3890:25: warning: incorrect type in assignment (different base types)
net/bluetooth/mgmt.c:3890:25:    expected unsigned short [usertype] num_handles
net/bluetooth/mgmt.c:3890:25:    got restricted __le16 [usertype]

Please make sure patches build cleanly with W=1 C=1 flags.