netdev - Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200604144145.GN102436@dhcp-12-153.nay.redhat.com>
Date:   Thu, 4 Jun 2020 22:41:45 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Jiri Benc <jbenc@...hat.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Eelco Chaudron <echaudro@...hat.com>, ast@...nel.org,
        Daniel Borkmann <daniel@...earbox.net>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Subject: Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

On Thu, Jun 04, 2020 at 02:37:23PM +0200, Toke Høiland-Jørgensen wrote:
> > Now I use the ethtool_stats.pl to count forwarding speed and here is the result:
> >
> > With kernel 5.7(ingress i40e, egress i40e)
> > XDP:
> > bridge: 1.8M PPS
> > xdp_redirect_map:
> >   generic mode: 1.9M PPS
> >   driver mode: 10.4M PPS
> 
> Ah, now we're getting somewhere! :)
> 
> > Kernel 5.7 + my patch(ingress i40e, egress i40e)
> > bridge: 1.8M
> > xdp_redirect_map:
> >   generic mode: 1.86M PPS
> >   driver mode: 10.17M PPS
> 
> Right, so this corresponds to a ~2ns overhead (10**9/10400000 -
> 10**9/10170000). This is not too far from being in the noise, I suppose;
> is the difference consistent?

Sorry, I didn't get, what different consistent do you mean?

> 
> > xdp_redirect_map_multi:
> >   generic mode: 1.53M PPS
> >   driver mode: 7.22M PPS
> >
> > Kernel 5.7 + my patch(ingress i40e, egress veth)
> > xdp_redirect_map:
> >   generic mode: 1.38M PPS
> >   driver mode: 4.15M PPS
> > xdp_redirect_map_multi:
> >   generic mode: 1.13M PPS
> >   driver mode: 3.55M PPS

With XDP_DROP in veth perr, the number looks much better

xdp_redirect_map:
  generic mode: 1.64M PPS
  driver mode: 13.3M PPS
xdp_redirect_map_multi:
  generic mode: 1.29M PPS
  driver mode: 8.5M PPS

> >
> > Kernel 5.7 + my patch(ingress i40e, egress i40e + veth)
> > xdp_redirect_map_multi:
> >   generic mode: 1.13M PPS
> >   driver mode: 3.47M PPS

But I don't know why this one get even a little slower..

xdp_redirect_map_multi:
  generic mode: 0.96M PPS
  driver mode: 3.14M PPS

Thanks
Hangbin