netdev - Re: [PATCH net] net: ethernet: mvneta: fix MVNETA_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200605.131349.189750898730910530.davem@davemloft.net>
Date:   Fri, 05 Jun 2020 13:13:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bloodyreaper@...dex.ru
Cc:     kuba@...nel.org, thomas.petazzoni@...tlin.com, ast@...nel.org,
        daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
        sven.auhagen@...eatech.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM
 alignment

From: Alexander Lobakin <bloodyreaper@...dex.ru>
Date: Fri,  5 Jun 2020 15:53:24 +0300

> Commit ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero")
> added headroom alignment check against 8.
> Hovewer (if we imagine that NET_SKB_PAD or XDP_PACKET_HEADROOM is not
> aligned to cacheline size), it actually aligns headroom down, while
> skb/xdp_buff headroom should be *at least* equal to one of the values
> (depending on XDP prog presence).
> So, fix the check to align the value up. This satisfies both
> hardware/driver and network stack requirements.
> 
> Fixes: ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero")
> Signed-off-by: Alexander Lobakin <bloodyreaper@...dex.ru>

Applied, thank you.