netdev - Re: [PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200605.131634.322571423468863173.davem@davemloft.net>
Date:   Fri, 05 Jun 2020 13:16:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     antoine.tenart@...tlin.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        michael@...le.cc, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: mscc: fix Serdes configuration in
 vsc8584_config_init

From: Antoine Tenart <antoine.tenart@...tlin.com>
Date: Fri,  5 Jun 2020 16:00:09 +0200

> When converting the MSCC PHY driver to shared PHY packages, the Serdes
> configuration in vsc8584_config_init was modified to use 'base_addr'
> instead of 'base' as the port number. But 'base_addr' isn't equal to
> 'addr' for all PHYs inside the package, which leads to the Serdes still
> being enabled on those ports. This patch fixes it.
> 
> Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared")
> Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Applied, thank you.