netdev - Re: [PATCH net] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200605172725.71d65c78@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 5 Jun 2020 17:27:25 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pooja Trivedi <poojatrivedi@...il.com>
Cc:     borisp@...lanox.com, aviadye@...lanox.com,
        john.fastabend@...il.com, daniel@...earbox.net,
        davem@...emloft.net, vakul.garg@....com, netdev@...r.kernel.org,
        linux-crypto@...r.kernel.org,
        mallesham.jatharkonda@...convergence.com, josh.tway@...ckpath.com,
        pooja.trivedi@...ckpath.com
Subject: Re: [PATCH net] net/tls(TLS_SW): Add selftest for 'chunked'
 sendfile test

On Fri,  5 Jun 2020 16:01:18 +0000 Pooja Trivedi wrote:
> This selftest tests for cases where sendfile's 'count'
> parameter is provided with a size greater than the intended
> file size.
> 
> Motivation: When sendfile is provided with 'count' parameter
> value that is greater than the size of the file, kTLS example
> fails to send the file correctly. Last chunk of the file is
> not sent, and the data integrity is compromised.
> The reason is that the last chunk has MSG_MORE flag set
> because of which it gets added to pending records, but is
> not pushed.
> Note that if user space were to send SSL_shutdown control
> message, pending records would get flushed and the issue
> would not happen. So a shutdown control message following
> sendfile can mask the issue.
> 
> Signed-off-by: Pooja Trivedi <pooja.trivedi@...ckpath.com>
> Signed-off-by: Mallesham Jatharkonda <mallesham.jatharkonda@...convergence.com>
> Signed-off-by: Josh Tway <josh.tway@...ckpath.com>

Looks good to me, but I'm not 100% sure we want to merge it before 
the fix is merged.

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Thanks!