netdev - Re: [PATCH] rhashtable: Drop raw RCU deref in nested_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 06 Jun 2020 15:51:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     herbert@...dor.apana.org.au
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] rhashtable: Drop raw RCU deref in nested_table_free

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 3 Jun 2020 18:12:43 +1000

> This patch replaces some unnecessary uses of rcu_dereference_raw
> in the rhashtable code with rcu_dereference_protected.
> 
> The top-level nested table entry is only marked as RCU because it
> shares the same type as the tree entries underneath it.  So it
> doesn't need any RCU protection.
> 
> We also don't need RCU protection when we're freeing a nested RCU
> table because by this stage we've long passed a memory barrier
> when anyone could change the nested table.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks Herbert.