netdev - Re: [PATCH net] mlxsw: core: Use different get_trend() callbacks for different thermal zones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200607.170031.441322781685186952.davem@davemloft.net>
Date:   Sun, 07 Jun 2020 17:00:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, jiri@...lanox.com,
        vadimp@...lanox.com, mlxsw@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net] mlxsw: core: Use different get_trend() callbacks
 for different thermal zones

From: Ido Schimmel <idosch@...sch.org>
Date: Sun,  7 Jun 2020 11:10:27 +0300

> From: Vadim Pasternak <vadimp@...lanox.com>
> 
> The driver registers three different types of thermal zones: For the
> ASIC itself, for port modules and for gearboxes.
> 
> Currently, all three types use the same get_trend() callback which does
> not work correctly for the ASIC thermal zone. The callback assumes that
> the device data is of type 'struct mlxsw_thermal_module', whereas for
> the ASIC thermal zone 'struct mlxsw_thermal' is passed as device data.
> 
> Fix this by using one get_trend() callback for the ASIC thermal zone and
> another for the other two types.
> 
> Fixes: 6f73862fabd9 ("mlxsw: core: Add the hottest thermal zone detection")
> Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied and queued up for -stable, thanks.