netdev - Re: [PATCH 8/8 net] net: remove indirect block netdev event registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd6aaf74-d7fc-9f84-f872-7ee4e3a971c3@intel.com>
Date:   Mon, 8 Jun 2020 15:37:42 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netfilter-devel@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org, paulb@...lanox.com, ozsh@...lanox.com,
        vladbu@...lanox.com, jiri@...nulli.us, kuba@...nel.org,
        saeedm@...lanox.com, michael.chan@...adcom.com
Subject: Re: [PATCH 8/8 net] net: remove indirect block netdev event
 registration



On 6/8/2020 2:47 PM, Pablo Neira Ayuso wrote:
> On Mon, Jun 08, 2020 at 02:07:57PM -0700, Jacob Keller wrote:
>>
>>
>> On 5/13/2020 9:41 AM, Pablo Neira Ayuso wrote:
>>> Drivers do not register to netdev events to set up indirect blocks
>>> anymore. Remove __flow_indr_block_cb_register() and
>>> __flow_indr_block_cb_unregister().
>>>
>>> The frontends set up the callbacks through flow_indr_dev_setup_block()
>>>
>>> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
>>
>> This commit failed to remove the prototypes from the header file:
>> include/net/flow_offload.h
> 
> Thanks for reporting.
> 
> I'm attaching a sketch, I will submit this formally later.
> 

The sketch looks good to me.

Regards,
Jake