netdev - RE: [RFC PATCH net-next 04/10] ethtool: Add link extended state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Jun 2020 10:03:01 +0000
From:   Amit Cohen <amitc@...lanox.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "corbet@....net" <corbet@....net>, Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "gustavo@...eddedor.com" <gustavo@...eddedor.com>,
        "cforno12@...ux.vnet.ibm.com" <cforno12@...ux.vnet.ibm.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "linux@...pel-privat.de" <linux@...pel-privat.de>,
        "alexandru.ardelean@...log.com" <alexandru.ardelean@...log.com>,
        Aya Levin <ayal@...lanox.com>,
        Petr Machata <petrm@...lanox.com>, mlxsw <mlxsw@...lanox.com>,
        "liuhangbin@...il.com" <liuhangbin@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: RE: [RFC PATCH net-next 04/10] ethtool: Add link extended state

Andrew Lunn <andrew@...n.ch> writes:

>> +/**
>> + * enum ethtool_ext_substate_cable_issue - more information in
>> + * addition to ETHTOOL_EXT_STATE_CABLE_ISSUE.
>> + */
>> +enum ethtool_ext_substate_cable_issue {
>> +	ETHTOOL_EXT_SUBSTATE_UNSUPPORTED_CABLE = 1,
>> +	ETHTOOL_EXT_SUBSTATE_SHORTED_CABLE,
>> +};
>
>I'm not too happy about shorted cable. I can see this getting extended to open cable, shorted to another pair, etc. It then becomes a duplicate of the PHY cable testing infrastructure. A more generic
>
>> +	ETHTOOL_EXT_SUBSTATE_CABLE_TEST_FAILURE,
>
>would be better, and then the user can use then use the cable testing infrastructure to get the full details.
>

Ok, makes sense.

>	Andrew