netdev - Re: [RFC PATCH bpf-next 0/2] bpf_redirect_map() tail call detection and xdp_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o8ps80gc.fsf@toke.dk>
Date:   Tue, 09 Jun 2020 22:10:27 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Björn Töpel <bjorn.topel@...il.com>,
        ast@...nel.org, daniel@...earbox.net, bpf@...r.kernel.org,
        john.fastabend@...il.com
Cc:     Björn Töpel <bjorn.topel@...il.com>,
        magnus.karlsson@...el.com, netdev@...r.kernel.org,
        brouer@...hat.com, maciej.fijalkowski@...el.com,
        bjorn.topel@...el.com
Subject: Re: [RFC PATCH bpf-next 0/2] bpf_redirect_map() tail call detection and xdp_do_redirect() avoidance

Björn Töpel <bjorn.topel@...il.com> writes:

> Is this a good idea? I have only measured for AF_XDP redirects, but
> all XDP_REDIRECT targets should benefit. For AF_XDP the rxdrop
> scenario went from 21.5 to 23.2 Mpps on my machine.

I like it! I guess in the end the feasibility will depend on the quality
tail call detection, which I don't have any ideas for improving. I'm
sure someone else will, though :)

-Toke