netdev - Re: [PATCH net] net: mvneta: do not redirect frames during reconfiguration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200609.142901.3888767961952002.davem@davemloft.net>
Date:   Tue, 09 Jun 2020 14:29:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lorenzo@...nel.org
Cc:     netdev@...r.kernel.org, thomas.petazzoni@...tlin.com,
        lorenzo.bianconi@...hat.com, brouer@...hat.com
Subject: Re: [PATCH net] net: mvneta: do not redirect frames during
 reconfiguration

From: Lorenzo Bianconi <lorenzo@...nel.org>
Date: Tue,  9 Jun 2020 00:02:39 +0200

> Disable frames injection in mvneta_xdp_xmit routine during hw
> re-configuration in order to avoid hardware hangs
> 
> Fixes: b0a43db9087a ("net: mvneta: add XDP_TX support")
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

Looking around, I wonder if the fundamental difference from the normal
TX path is that the XDP path doesn't use the TXQ enable/disable
machinery and checks like the normal ndo_start_xmit() paths do.

And that's why only the XDP path has this issue.

I'll apply this, so that the bug is fixed, but note that I consider
this kind of change adding a new flags mask and one state bit to solve
a problem to be ultimately inelegant and ususally pointing out a more
fundamental issue.

Thank you.