netdev - Re: [PATCH iproute2 net-next 1/2] ipnexthop: support for fdb nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c72763ac-98a4-1bac-85aa-fd17985fc916@gmail.com>
Date:   Wed, 10 Jun 2020 10:06:40 -0600
From:   David Ahern <dsahern@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        nikolay@...ulusnetworks.com
Subject: Re: [PATCH iproute2 net-next 1/2] ipnexthop: support for fdb nexthops

On 6/8/20 9:46 PM, Roopa Prabhu wrote:
> @@ -70,6 +71,12 @@ static int nh_dump_filter(struct nlmsghdr *nlh, int reqlen)
>  			return err;
>  	}
>  
> +	if (filter.fdb) {
> +		addattr_l(nlh, reqlen, NHA_FDB, NULL, 0);

missing 'err = '
> +		if (err)
> +			return err;
> +	}
> +
>  	return 0;
>  }
>  
> @@ -131,6 +138,7 @@ static int ipnh_flush(unsigned int all)
>  		filter.groups = 1;
>  		filter.ifindex = 0;
>  		filter.master = 0;
> +		filter.fdb = 1;

This should not be needed. The point of this block is to flush groups
first and then standalone nexthops on a second pass. Adding fdb = 1 here
means only fdb groups are flushed in the first round.