netdev - Re: [PATCH v4 0/3] Add support for SQI and master-slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200610200535.zkozejqc3ssxpeam@lion.mk-sys.cz>
Date:   Wed, 10 Jun 2020 22:05:35 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        "John W. Linville" <linville@...driver.com>,
        David Jander <david@...tonic.nl>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Russell King <linux@...linux.org.uk>, mkl@...gutronix.de,
        Marek Vasut <marex@...x.de>,
        Christian Herber <christian.herber@....com>,
        Amit Cohen <amitc@...lanox.com>,
        Petr Machata <petrm@...lanox.com>
Subject: Re: [PATCH v4 0/3] Add support for SQI and master-slave

On Wed, Jun 10, 2020 at 10:37:41AM +0200, Oleksij Rempel wrote:
> This patch set is extending ethtool to make it more usable on automotive
> PHYs like NXP TJA11XX.
> 
> They make use of new KAPI (currently in net-next, will go probably to the
> kernel 5.8-rc1):
> - PHY master-slave role configuration and status informaton. Mostly needed
>   for 100Base-T1 PHYs due the lack of autonegatiation support.
> - Signal Quality Index to investigate cable related issues.
> 
> changes v4:
> - rebase is against current ethtool master
> - pull headers from current kernel master
> - use tabs instead of spaces in the manual
> 
> changes v3:
> - rename "Port mode" to "master-slave"
> - use [preferred|forced]-[master|slave] for information and
>   configuration
> 
> changes v2:
> - add master-slave information to the "ethtool --help" and man page
> - move KAPI update changes to the separate patch. 
> 
> Oleksij Rempel (3):
>   update UAPI header copies
>   netlink: add master/slave configuration support
>   netlink: add LINKSTATE SQI support
> 
>  ethtool.8.in                 |  19 +++++
>  ethtool.c                    |   1 +
>  netlink/desc-ethtool.c       |   4 +
>  netlink/settings.c           |  66 +++++++++++++++
>  uapi/linux/ethtool.h         |  16 +++-
>  uapi/linux/ethtool_netlink.h | 153 ++++++++++++++++++++++++++++++++++-
>  uapi/linux/genetlink.h       |   2 +
>  uapi/linux/if_link.h         |   1 +
>  uapi/linux/netlink.h         | 103 +++++++++++++++++++++++
>  uapi/linux/rtnetlink.h       |   6 ++
>  10 files changed, 369 insertions(+), 2 deletions(-)
> 
> -- 
> 2.27.0
> 

The series looks good to me, I'll wait for another day or two for other
comments and apply it there are no objections.

Michal