netdev - Re: [PATCH net 5/5] net: ipa: warn if gsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200610.163658.2043816131147701638.davem@davemloft.net>
Date:   Wed, 10 Jun 2020 16:36:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     elder@...aro.org
Cc:     kuba@...nel.org, evgreen@...omium.org, subashab@...eaurora.org,
        cpratapa@...eaurora.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 5/5] net: ipa: warn if gsi_trans structure is too
 big

From: Alex Elder <elder@...aro.org>
Date: Wed, 10 Jun 2020 14:53:32 -0500

> When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are
> enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes
> to 56 bytes currently).  As a consequence the size of the gsi_trans
> structure exceeds 128 bytes, and this triggers a BUILD_BUG_ON()
> error.
> 
> These are useful configuration options to enable, so rather than
> causing a build failure, just issue a warning message at run time
> if the structure is larger than we'd prefer.
> 
> Signed-off-by: Alex Elder <elder@...aro.org>

Please fix the problem or prevent the build of this module in such
configurations since obviously it will fail to load successfully.

It is completely unexpected for something to fail at run time that
could be detected at build time.