netdev - Re: [PATCH] xdp: fix xsk_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200611.124411.1798325783779516035.davem@davemloft.net>
Date:   Thu, 11 Jun 2020 12:44:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lirongqing@...du.com
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH] xdp: fix xsk_generic_xmit errno

From: Li RongQing <lirongqing@...du.com>
Date: Thu, 11 Jun 2020 13:11:06 +0800

> @@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk)
>  		len = desc.len;
>  		skb = sock_alloc_send_skb(sk, len, 1, &err);
>  		if (unlikely(!skb)) {
> -			err = -EAGAIN;
>  			goto out;
>  		}

Since the result is a single-statement basic block you must remove the
curly braces.