netdev - Re: [PATCH iproute2] ip address: Fix loop initial declarations are only allowed in C99

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200611150528.53a6f14c@hermes.lan>
Date:   Thu, 11 Jun 2020 15:05:28 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Roi Dayan <roid@...lanox.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH iproute2] ip address: Fix loop initial declarations are
 only allowed in C99

On Thu, 11 Jun 2020 20:35:43 +0300
Roi Dayan <roid@...lanox.com> wrote:

> On some distros, i.e. rhel 7.6, compilation fails with the following:
> 
> ipaddress.c: In function ‘lookup_flag_data_by_name’:
> ipaddress.c:1260:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
>   for (int i = 0; i < ARRAY_SIZE(ifa_flag_data); ++i) {
>   ^
> ipaddress.c:1260:2: note: use option -std=c99 or -std=gnu99 to compile your code
> 
> This commit fixes the single place needed for compilation to pass.
> 
> Fixes: 9d59c86e575b ("iproute2: ip addr: Organize flag properties structurally")
> Signed-off-by: Roi Dayan <roid@...lanox.com>

Agree.
Applied