netdev - Re: [PATCH net 2/2] flow_offload: fix miss cleanup flow_block_cb of indr_setup_ft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Jun 2020 11:47:02 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     wenxu@...oud.cn
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net 2/2] flow_offload: fix miss cleanup flow_block_cb of
 indr_setup_ft_cb type

On Thu, Jun 11, 2020 at 11:30:17AM +0800, wenxu@...oud.cn wrote:
> From: wenxu <wenxu@...oud.cn>
> 
> Currently indr setup supoort both indr_setup_ft_cb and indr_setup_tc_cb.
> But the __flow_block_indr_cleanup only check the indr_setup_tc_cb in
> mlx5e driver.
> It is better to just check the indr_release_cb, all the setup_cb type
> share the same release_cb.

I think patch 1/2 and 2/2 should be collapsed into one single patch.

(Non-native English) suggestion for your patch description:

"If the representor is removed, then identify the indirect flow_blocks
that need to be removed by the release callback."

Thank you.