netdev - RE: [Intel-wired-lan] [PATCH net 1/3] ixgbe: protect ring accesses with READ- and WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Jun 2020 15:42:30 +0000
From:   "Bowers, AndrewX" <andrewx.bowers@...el.com>
To:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net 1/3] ixgbe: protect ring accesses
 with READ- and WRITE_ONCE

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Ciara Loftus
> Sent: Tuesday, June 9, 2020 6:20 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Topel, Bjorn <bjorn.topel@...el.com>;
> Karlsson, Magnus <magnus.karlsson@...el.com>
> Subject: [Intel-wired-lan] [PATCH net 1/3] ixgbe: protect ring accesses with
> READ- and WRITE_ONCE
> 
> READ_ONCE should be used when reading rings prior to accessing the
> statistics pointer. Introduce this as well as the corresponding WRITE_ONCE
> usage when allocating and freeing the rings, to ensure protected access.
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@...el.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c  | 12 ++++++------
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 14 +++++++++++---
>  2 files changed, 17 insertions(+), 9 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@...el.com>