netdev - Re: [PATCH bpf] tools/bpftool: fix skeleton codegen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKiyCaqPAO0yCuiFJOmvrxexxkaXJNCQEwxpsHjcm6j8g@mail.gmail.com>
Date:   Fri, 12 Jun 2020 15:26:48 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf] tools/bpftool: fix skeleton codegen

On Fri, Jun 12, 2020 at 3:05 PM Tobias Klauser <tklauser@...tanz.ch> wrote:
>
> On 2020-06-12 at 22:16:03 +0200, Andrii Nakryiko <andriin@...com> wrote:
> > Remove unnecessary check at the end of codegen() routine which makes codegen()
> > to always fail and exit bpftool with error code. Positive value of variable
> > n is not an indicator of a failure.
> >
> > Cc: Tobias Klauser <tklauser@...tanz.ch>
> > Fixes: 2c4779eff837 ("tools, bpftool: Exit on error in function codegen")
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
>
> Reviewed-by: Tobias Klauser <tklauser@...tanz.ch>
>
> Sorry about this, thanks for fixing it.

Applied. Thanks