netdev - Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200612084244.4ab4f6c6@carbon>
Date:   Fri, 12 Jun 2020 08:42:44 +0200
From:   Jesper Dangaard Brouer <jbrouer@...hat.com>
To:     Gaurav Singh <gaurav1086@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        KP Singh <kpsingh@...omium.org>,
        netdev@...r.kernel.org (open list:XDP (eXpress Data Path)),
        bpf@...r.kernel.org (open list:XDP (eXpress Data Path)),
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

On Thu, 11 Jun 2020 20:36:40 -0400
Gaurav Singh <gaurav1086@...il.com> wrote:

> Replace malloc/memset with calloc
> 
> Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info")
> Signed-off-by: Gaurav Singh <gaurav1086@...il.com>

Above is the correct use of Fixes + Signed-off-by.

Now you need to update/improve the description, to also
mention/describe that this also solves the bug you found.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer