netdev - Re: r816x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3538ceba-5bb6-7b03-ac36-1bf23c29f771@pp.inet.fi>
Date:   Sat, 13 Jun 2020 17:43:51 +0300
From:   Lauri Jakku <lauri.jakku@...inet.fi>
To:     hkallweit1@...il.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: r816x driver

Hi,

On 13.6.2020 1.46, Lauri Jakku wrote:
> Hi,
>
> As you may recall i've started to debug r816x driver: Why it does not 
> work, and i'm allmost
>
> certain there is something fishy in probeing ... 1st try always fails, 
> and second try with
>
> my patch seems to work ok.
>
>
> https://forum.manjaro.org/t/re-r8168-kernel-5-6-3-driver-broken/147727/2
>
>
> Something is not done similar way compared to 1st and 2nd load of the 
> module. I pin pointed,
>
> or have a clue, that a line from drivers/net/phy/phy_device.c witch is 
> not executed when
>
> loading first time:
>
> static int phy_probe(struct device *dev)
> {
>         struct phy_device *phydev = to_phy_device(dev);
>         struct device_driver *drv = phydev->mdio.dev.driver;
>         struct phy_driver *phydrv = to_phy_driver(drv);
>         int err = 0;
>
>         phydev->drv = phydrv; <--- This is never done in probe of 
> r8169_main.c
>
>
> That line is not executed when driver is loaded with modprobe, but 
> when load->remove->reload
>
> cycle is done, it is ok. I have no clue now where to look, but when i 
> got time i'll start
>
> debugging some more.
>
>
>


> --Lja
>