netdev - Re: [PATCH 1/1] mvpp2: ethtool rxtx stats fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200615090843.jh7ua4jlckey2qbe@SvensMacbookPro.hq.voleatech.com>
Date:   Mon, 15 Jun 2020 11:08:43 +0200
From:   Sven Auhagen <sven.auhagen@...eatech.de>
To:     Matteo Croce <technoboy85@...il.com>
Cc:     netdev@...r.kernel.org, antoine.tenart@...tlin.com,
        gregory.clement@...tlin.com, maxime.chevallier@...tlin.com,
        thomas.petazzoni@...tlin.com, miquel.raynal@...tlin.com,
        Marcin Wojtas <mw@...ihalf.com>, lorenzo@...nel.org
Subject: Re: [PATCH 1/1] mvpp2: ethtool rxtx stats fix

On Mon, Jun 15, 2020 at 12:23:20AM +0000, Matteo Croce wrote:
> On Sun, Jun 14, 2020 at 7:19 AM Sven Auhagen <sven.auhagen@...eatech.de> wrote:
> >
> > The ethtool rx and tx queue statistics are reporting wrong values.
> > Fix reading out the correct ones.
> >
> > Signed-off-by: Sven Auhagen <sven.auhagen@...eatech.de>
> 
> Hi Sven,
> 
> seems to work as expected now:
> 
> # ethtool -S eth2 |grep rxq
>     rxq_0_desc_enqueue: 983
>     rxq_0_queue_full_drops: 0
>     rxq_0_packets_early_drops: 0
>     rxq_0_packets_bm_drops: 0
>     rxq_1_desc_enqueue: 14
>     rxq_1_queue_full_drops: 0
>     rxq_1_packets_early_drops: 0
>     rxq_1_packets_bm_drops: 0
>     rxq_2_desc_enqueue: 12
>     rxq_2_queue_full_drops: 0
>     rxq_2_packets_early_drops: 0
>     rxq_2_packets_bm_drops: 0
>     rxq_3_desc_enqueue: 4
>     rxq_3_queue_full_drops: 0
>     rxq_3_packets_early_drops: 0
>     rxq_3_packets_bm_drops: 0
> 
> If you manage to find the commit which introduced this tag, please add
> a Fixes tag.

Hi Matteo,

I looked through the commits from the past 2 years but no luck.
This must have been in there for a while.

Best
Sven

> 
> Thanks,
> -- 
> Matteo Croce
> 
> perl -e 'for($t=0;;$t++){print chr($t*($t>>8|$t>>13)&255)}' |aplay