netdev - Re: [PATCH net v2 1/4] flow_offload: fix incorrect cleanup for indirect flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <vbfr1ug612q.fsf@mellanox.com>
Date:   Mon, 15 Jun 2020 14:05:49 +0300
From:   Vlad Buslov <vladbu@...lanox.com>
To:     wenxu@...oud.cn
Cc:     netdev@...r.kernel.org, pablo@...filter.org, vladbu@...lanox.com
Subject: Re: [PATCH net v2 1/4] flow_offload: fix incorrect cleanup for indirect flow_blocks

On Sat 13 Jun 2020 at 12:25, wenxu@...oud.cn wrote:
> From: wenxu <wenxu@...oud.cn>
>
> If the representor is removed, then identify the indirect
> flow_blocks that need to be removed by the release callback.
>
> Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
> Signed-off-by: wenxu <wenxu@...oud.cn>
> ---

Hi,

It is hard for me to review the code itself (because it lacks cover
letter, doesn't describe in any detail what problem it tries to fix or
provide steps to reproduce it, and lacks a changelog), but this version
of the series passes our test suite.

Regards,
Vlad