netdev - Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CmpXtpAaY+zKG-ofPNYHTChTiDtwCAnd8uYQSqyJ8hLE891Q@mail.gmail.com>
Date:   Mon, 15 Jun 2020 16:45:22 +0300
From:   Yehezkel Bernat <yehezkelshb@...il.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     linux-usb@...r.kernel.org, Michael Jamet <michael.jamet@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Lukas Wunner <lukas@...ner.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
>
> diff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h
> index ff397c0d5c07..5db2b11ab085 100644
> --- a/include/linux/thunderbolt.h
> +++ b/include/linux/thunderbolt.h
> @@ -504,8 +504,6 @@ struct tb_ring {
>  #define RING_FLAG_NO_SUSPEND   BIT(0)
>  /* Configure the ring to be in frame mode */
>  #define RING_FLAG_FRAME                BIT(1)
> -/* Enable end-to-end flow control */
> -#define RING_FLAG_E2E          BIT(2)
>

Isn't it better to keep it (or mark it as reserved) so it'll not cause
compatibility issues with older versions of the driver or with Windows?