netdev - Re: [PATCH 2/5] Huawei BMA: Adding Huawei BMA driver: host_cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c724b75-f90d-a0f2-fbdb-4cd220b8e142@infradead.org>
Date:   Mon, 15 Jun 2020 08:48:14 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     yunaixin03610@....com, netdev@...r.kernel.org
Cc:     yunaixin <yunaixin@...wei.com>
Subject: Re: [PATCH 2/5] Huawei BMA: Adding Huawei BMA driver: host_cdev_drv

Hi--

On 6/15/20 7:59 AM, yunaixin03610@....com wrote:
> diff --git a/drivers/net/ethernet/huawei/bma/Kconfig b/drivers/net/ethernet/huawei/bma/Kconfig
> index 1a92c1dd83f3..12979128fa9d 100644
> --- a/drivers/net/ethernet/huawei/bma/Kconfig
> +++ b/drivers/net/ethernet/huawei/bma/Kconfig
> @@ -1 +1,2 @@
> -source "drivers/net/ethernet/huawei/bma/edma_drv/Kconfig"
> \ No newline at end of file
> +source "drivers/net/ethernet/huawei/bma/edma_drv/Kconfig"
> +source "drivers/net/ethernet/huawei/bma/cdev_drv/Kconfig"
> \ No newline at end of file

Please fix those warnings above.

> diff --git a/drivers/net/ethernet/huawei/bma/Makefile b/drivers/net/ethernet/huawei/bma/Makefile
> index 8f589f7986d6..c9bbcbf2a388 100644
> --- a/drivers/net/ethernet/huawei/bma/Makefile
> +++ b/drivers/net/ethernet/huawei/bma/Makefile
> @@ -2,4 +2,5 @@
>  # Makefile for BMA software driver
>  # 
>  
> -obj-$(CONFIG_BMA) += edma_drv/
> \ No newline at end of file
> +obj-$(CONFIG_BMA) += edma_drv/
> +obj-$(CONFIG_BMA) += cdev_drv/
> \ No newline at end of file

Same here.

> diff --git a/drivers/net/ethernet/huawei/bma/cdev_drv/Kconfig b/drivers/net/ethernet/huawei/bma/cdev_drv/Kconfig
> new file mode 100644
> index 000000000000..97829c5487c2
> --- /dev/null
> +++ b/drivers/net/ethernet/huawei/bma/cdev_drv/Kconfig
> @@ -0,0 +1,11 @@
> +#
> +# Huawei BMA software driver configuration
> +#
> +
> +config BMA
> +	tristate "Huawei BMA Software Communication Driver"
> +
> +	---help---

Just use
	help
here.  Use of ---help--- is being phased out.

> +	  This driver supports Huawei BMA Software. It is used 
> +	  to communication between Huawei BMA and BMC software.

	  to communicate

> +

thanks.
-- 
~Randy