netdev - Re: [PATCH net] net: core: reduce recursion limit value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMArcTWXDb3RX3NjkU22Q9J417XKOt5ghzmQw5Yt0w=UGzH-nQ@mail.gmail.com>
Date:   Tue, 16 Jun 2020 19:49:00 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     Florian Westphal <fw@...len.de>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: core: reduce recursion limit value

On Tue, 16 Jun 2020 at 00:21, Florian Westphal <fw@...len.de> wrote:
>

Hi Florian,
Thank you for the review!

> Taehee Yoo <ap420073@...il.com> wrote:
> > In the current code, ->ndo_start_xmit() can be executed recursively only
> > 10 times because of stack memory.
> > But, in the case of the vxlan, 10 recursion limit value results in
> > a stack overflow.
> [..]
>
> > Fixes: 97cdcf37b57e ("net: place xmit recursion in softnet data")
>
> That commit did not change the recursion limit,
> 11a766ce915fc9f86 ("net: Increase xmit RECURSION_LIMIT to 10.") did?

You're right.
I will send a v2 patch.

Thanks!