netdev - Re: [PATCH net] tcp: grow window for OOO packets only for SACK flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQymw6xMVDjRX-rPJ0rHeMu_NfDp_XmdGjPqSUS9Wf7Q7Tw@mail.gmail.com>
Date:   Tue, 16 Jun 2020 09:47:24 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
Subject: Re: [PATCH net] tcp: grow window for OOO packets only for SACK flows

On Mon, Jun 15, 2020 at 11:37 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Back in 2013, we made a change that broke fast retransmit
> for non SACK flows.
>
> Indeed, for these flows, a sender needs to receive three duplicate
> ACK before starting fast retransmit. Sending ACK with different
> receive window do not count.
>
> Even if enabling SACK is strongly recommended these days,
> there still are some cases where it has to be disabled.
>
> Not increasing the window seems better than having to
> rely on RTO.
...
> Fixes: 4e4f1fc22681 ("tcp: properly increase rcv_ssthresh for ofo packets")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
> ---

Thanks for the fix, Eric!

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal