netdev - Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMdQvKtrzFtg9PwZhyMQ96S48ZLG5gAu3gk8m=k+tFVMHeshXQ@mail.gmail.com>
Date:   Wed, 17 Jun 2020 01:32:02 +0900
From:   Era Mayflower <mayflowerera@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

On Wed, Jun 17, 2020 at 10:02 AM Era Mayflower <mayflowerera@...il.com> wrote:
>
> On Tue, Jun 16, 2020 at 1:23 AM David Miller <davem@...emloft.net> wrote:
> >
> > From: Era Mayflower <mayflowerera@...il.com>
> > Date: Tue, 16 Jun 2020 00:41:14 +0900
> >
> > > +     if (tb_sa[MACSEC_SA_ATTR_PN]) {
> >
> > validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-NULL, so
> > you don't need to add this check here.
> >
>
> validate_add_rxsa() did not originally contain that requirement.
> It does exist in validate_add_txsa(), which means that providing a PN
> is necessary only when creating TXSA.
> When creating an RXSA without providing a PN it will be set to 1
> (init_rx_sa+15).
> This is the original behavior which of course can be changed.
>
> - Era.

Sorry for the time issues, just noticed I sent the previous mail with
future time.
Fixed it permanently on my computer.