netdev - RE: [EXT] Re: [PATCH] net: fec: fix ref count leaking when pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR0402MB3607327188F1F9178A7E5BFBFF9D0@AM6PR0402MB3607.eurprd04.prod.outlook.com>
Date:   Tue, 16 Jun 2020 02:03:25 +0000
From:   Andy Duan <fugang.duan@....com>
To:     David Miller <davem@...emloft.net>,
        "navid.emamdoost@...il.com" <navid.emamdoost@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "emamd001@....edu" <emamd001@....edu>,
        "wu000273@....edu" <wu000273@....edu>,
        "kjlu@....edu" <kjlu@....edu>,
        "mccamant@...umn.edu" <mccamant@...umn.edu>
Subject: RE: [EXT] Re: [PATCH] net: fec: fix ref count leaking when
 pm_runtime_get_sync fails

From: David Miller <davem@...emloft.net> Sent: Tuesday, June 16, 2020 4:42 AM
> From: Navid Emamdoost <navid.emamdoost@...il.com>
> Date: Sun, 14 Jun 2020 00:38:01 -0500
> 
> > in fec_enet_mdio_read, fec_enet_mdio_write, fec_enet_get_regs,
> > fec_enet_open and fec_drv_remove, pm_runtime_get_sync is called which
> > increments the counter even in case of failure, leading to incorrect
> > ref count. In case of failure, decrement the ref count before returning.
> >
> > Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
> 
> This does not apply to the net tree.

Wolfram Sang wonder if such de-reference can be better handled by pm runtime core code.
https://lkml.org/lkml/2020/6/14/76