netdev - Re: [PATCH bpf] devmap: use bpf_map_area_alloc() for allocating hash buckets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQK5eSxpgc=-SoQgiQqQJfeYcAwho7AAZvdQBCuetK0w_A@mail.gmail.com>
Date:   Wed, 17 Jun 2020 10:03:03 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Toke Høiland-Jørgensen <toke@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Xiumei Mu <xmu@...hat.com>
Subject: Re: [PATCH bpf] devmap: use bpf_map_area_alloc() for allocating hash buckets

On Tue, Jun 16, 2020 at 11:07 PM John Fastabend
<john.fastabend@...il.com> wrote:
>
> Toke Høiland-Jørgensen wrote:
> > Syzkaller discovered that creating a hash of type devmap_hash with a large
> > number of entries can hit the memory allocator limit for allocating
> > contiguous memory regions. There's really no reason to use kmalloc_array()
> > directly in the devmap code, so just switch it to the existing
> > bpf_map_area_alloc() function that is used elsewhere.
> >
> > Reported-by: Xiumei Mu <xmu@...hat.com>
> > Fixes: 6f9d451ab1a3 ("xdp: Add devmap_hash map type for looking up devices by hashed index")
> > Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> > ---
> >  kernel/bpf/devmap.c | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> >
>
> Acked-by: John Fastabend <john.fastabend@...il.com>

Applied. Thanks