netdev - RE: [PATCH bpf-next] bpf: sk_storage: Prefer to get a free cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5eeaf50fec904_38b82b28075185c44c@john-XPS-13-9370.notmuch>
Date:   Wed, 17 Jun 2020 22:01:03 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Martin KaFai Lau <kafai@...com>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, kernel-team@...com,
        netdev@...r.kernel.org
Subject: RE: [PATCH bpf-next] bpf: sk_storage: Prefer to get a free cache_idx

Martin KaFai Lau wrote:
> The cache_idx is currently picked by RR.  There is chance that
> the same cache_idx will be picked by multiple sk_storage_maps while
> other cache_idx is still unused.  e.g. It could happen when the
> sk_storage_map is recreated during the restart of the user
> space process.
> 
> This patch tracks the usage count for each cache_idx.  There is
> 16 of them now (defined in BPF_SK_STORAGE_CACHE_SIZE).
> It will try to pick the free cache_idx.  If none was found,
> it would pick one with the minimal usage count.
> 
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---
>  net/core/bpf_sk_storage.c | 41 +++++++++++++++++++++++++++++++++++----
>  1 file changed, 37 insertions(+), 4 deletions(-)
> 

Acked-by: John Fastabend <john.fastabend@...il.com>