netdev - Re: [net-next 02/15] iecm: Add framework set of header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57110139759cc77f21a150a3faed0d2584dfbe21.camel@perches.com>
Date:   Wed, 17 Jun 2020 22:32:33 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:     Alice Michael <alice.michael@...el.com>, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com,
        Alan Brady <alan.brady@...el.com>,
        Phani Burra <phani.r.burra@...el.com>,
        Joshua Hay <joshua.a.hay@...el.com>,
        Madhu Chittim <madhu.chittim@...el.com>,
        Pavan Kumar Linga <pavan.kumar.linga@...el.com>,
        Donald Skidmore <donald.c.skidmore@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>
Subject: Re: [net-next 02/15] iecm: Add framework set of header files

On Wed, 2020-06-17 at 22:13 -0700, Jeff Kirsher wrote:
> From: Alice Michael <alice.michael@...el.com>
[]
> diff --git a/include/linux/net/intel/iecm_controlq_api.h b/include/linux/net/intel/iecm_controlq_api.h
[]
> +enum iecm_ctlq_err {
> +	IECM_CTLQ_RC_OK		= 0,  /* Success */

Why is it necessary to effectively duplicate the
generic error codes with different error numbers?

> +	IECM_CTLQ_RC_EPERM	= 1,  /* Operation not permitted */
> +	IECM_CTLQ_RC_ENOENT	= 2,  /* No such element */
> +	IECM_CTLQ_RC_ESRCH	= 3,  /* Bad opcode */
> +	IECM_CTLQ_RC_EINTR	= 4,  /* Operation interrupted */
> +	IECM_CTLQ_RC_EIO	= 5,  /* I/O error */
> +	IECM_CTLQ_RC_ENXIO	= 6,  /* No such resource */
> +	IECM_CTLQ_RC_E2BIG	= 7,  /* Arg too long */
> +	IECM_CTLQ_RC_EAGAIN	= 8,  /* Try again */
> +	IECM_CTLQ_RC_ENOMEM	= 9,  /* Out of memory */
> +	IECM_CTLQ_RC_EACCES	= 10, /* Permission denied */
> +	IECM_CTLQ_RC_EFAULT	= 11, /* Bad address */
> +	IECM_CTLQ_RC_EBUSY	= 12, /* Device or resource busy */
> +	IECM_CTLQ_RC_EEXIST	= 13, /* object already exists */
> +	IECM_CTLQ_RC_EINVAL	= 14, /* Invalid argument */
> +	IECM_CTLQ_RC_ENOTTY	= 15, /* Not a typewriter */
> +	IECM_CTLQ_RC_ENOSPC	= 16, /* No space left or allocation failure */
> +	IECM_CTLQ_RC_ENOSYS	= 17, /* Function not implemented */
> +	IECM_CTLQ_RC_ERANGE	= 18, /* Parameter out of range */
> +	IECM_CTLQ_RC_EFLUSHED	= 19, /* Cmd flushed due to prev cmd error */
> +	IECM_CTLQ_RC_BAD_ADDR	= 20, /* Descriptor contains a bad pointer */
> +	IECM_CTLQ_RC_EMODE	= 21, /* Op not allowed in current dev mode */
> +	IECM_CTLQ_RC_EFBIG	= 22, /* File too big */
> +	IECM_CTLQ_RC_ENOSEC	= 24, /* Missing security manifest */
> +	IECM_CTLQ_RC_EBADSIG	= 25, /* Bad RSA signature */
> +	IECM_CTLQ_RC_ESVN	= 26, /* SVN number prohibits this package */
> +	IECM_CTLQ_RC_EBADMAN	= 27, /* Manifest hash mismatch */
> +	IECM_CTLQ_RC_EBADBUF	= 28, /* Buffer hash mismatches manifest */
> +};