netdev - Re: [PATCH net-next v2 6/8] net: phy: mscc: timestamping and PHC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <159246479497.467274.13476034822528412319@kwain>
Date:   Thu, 18 Jun 2020 09:19:55 +0200
From:   Antoine Tenart <antoine.tenart@...tlin.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, andrew@...n.ch, f.fainelli@...il.com,
        hkallweit1@...il.com, richardcochran@...il.com,
        alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, allan.nielsen@...rochip.com,
        foss@...il.net
Subject: Re: [PATCH net-next v2 6/8] net: phy: mscc: timestamping and PHC support

Hello Jakub,

Quoting Jakub Kicinski (2020-06-17 18:32:17)
> On Wed, 17 Jun 2020 15:31:25 +0200 Antoine Tenart wrote:
> > This patch adds support for PHC and timestamping operations for the MSCC
> > PHY. PTP 1-step and 2-step modes are supported, over Ethernet and UDP.
> > 
> > To get and set the PHC time, a GPIO has to be used and changes are only
> > retrieved or committed when on a rising edge. The same GPIO is shared by
> > all PHYs, so the granularity of the lock protecting it has to be
> > different from the ones protecting the 1588 registers (the VSC8584 PHY
> > has 2 1588 blocks, and a single load/save pin).
> > 
> > Co-developed-by: Quentin Schulz <quentin.schulz@...tlin.com>
> > Signed-off-by: Quentin Schulz <quentin.schulz@...tlin.com>
> > Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>
> 
> drivers/net/phy/mscc/mscc_ptp.c:406:24: warning: restricted __be16 degrades to integer
> drivers/net/phy/mscc/mscc_ptp.c:407:24: warning: restricted __be16 degrades to integer
> drivers/net/phy/mscc/mscc_ptp.c:1213:23: warning: symbol 'vsc85xx_clk_caps' was not declared. Should it be static?
> 
> Please make sure you don't add warnings when built with W=1 C=1 flags.

I'll look into that.

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com