lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Jun 2020 14:56:40 +0200 From: Andrew Lunn <andrew@...n.ch> To: Florian Fainelli <f.fainelli@...il.com> Cc: netdev@...r.kernel.org, Vivien Didelot <vivien.didelot@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count On Wed, Jun 17, 2020 at 08:42:44PM -0700, Florian Fainelli wrote: > of_find_node_by_name() will do an of_node_put() on the "from" argument. > Fixes: afa3b592953b ("net: dsa: bcm_sf2: Ensure correct sub-node is parsed") > Signed-off-by: Florian Fainelli <f.fainelli@...il.com> > --- > drivers/net/dsa/bcm_sf2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c > index c1bd21e4b15c..9f62ba3e4345 100644 > --- a/drivers/net/dsa/bcm_sf2.c > +++ b/drivers/net/dsa/bcm_sf2.c > @@ -1154,6 +1154,8 @@ static int bcm_sf2_sw_probe(struct platform_device *pdev) > set_bit(0, priv->cfp.used); > set_bit(0, priv->cfp.unique); > > + /* Balance of_node_put() done by of_find_node_by_name() */ > + of_node_get(dn); > ports = of_find_node_by_name(dn, "ports"); That if_find_node_by_name() does a put is not very intuitive. Maybe document that as well in the kerneldocs? Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists