| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200618084347.21074cf5@kicinski-fedora-PC1C0HJN>
Date: Thu, 18 Jun 2020 08:43:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc: davem@...emloft.net, Alice Michael <alice.michael@...el.com>,
netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
Alan Brady <alan.brady@...el.com>,
Phani Burra <phani.r.burra@...el.com>,
Joshua Hay <joshua.a.hay@...el.com>,
Madhu Chittim <madhu.chittim@...el.com>,
Pavan Kumar Linga <pavan.kumar.linga@...el.com>,
Donald Skidmore <donald.c.skidmore@...el.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Sridhar Samudrala <sridhar.samudrala@...el.com>
Subject: Re: [net-next 14/15] iecm: Add iecm to the kernel build system
On Wed, 17 Jun 2020 22:13:43 -0700 Jeff Kirsher wrote:
> From: Alice Michael <alice.michael@...el.com>
>
> This introduces iecm as a module to the kernel, and adds
> relevant documentation.
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:45:17: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:45:17: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:45:17: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:47:17: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:47:17: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:47:17: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:54:9: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:54:9: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:54:9: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:57:9: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:57:9: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:57:9: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:58:9: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:58:9: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:58:9: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:59:9: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:59:9: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:59:9: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:62:15: warning: incorrect type in argument 1 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:62:15: expected void const volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:62:15: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:321:33: warning: incorrect type in assignment (different base types)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:321:33: expected restricted __le16 [usertype] pfid_vfid
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:321:33: got unsigned short [usertype] func_id
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:364:9: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:364:9: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:364:9: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:563:17: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:563:17: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:563:17: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_lib.c:49:13: warning: symbol 'iecm_mb_intr_clean' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_lib.c:70:9: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_lib.c:70:9: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_lib.c:70:9: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_lib.c:63:6: warning: symbol 'iecm_mb_irq_enable' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_lib.c:77:5: warning: symbol 'iecm_mb_intr_req_irq' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_lib.c:104:6: warning: symbol 'iecm_get_mb_vec_id' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_lib.c:122:5: warning: symbol 'iecm_mb_intr_init' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_lib.c:140:6: warning: symbol 'iecm_intr_distribute' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_lib.c:299:21: warning: incorrect type in assignment (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_lib.c:299:21: expected unsigned char [usertype] *hw_addr
../drivers/net/ethernet/intel/iecm/iecm_lib.c:299:21: got void [noderef] <asn:2> *
../drivers/net/ethernet/intel/iecm/iecm_lib.c:417:5: warning: symbol 'iecm_vport_rel' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_lib.c:748:6: warning: symbol 'iecm_deinit_task' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:84:6: warning: symbol 'iecm_tx_buf_rel_all' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:115:6: warning: symbol 'iecm_tx_desc_rel' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:136:6: warning: symbol 'iecm_tx_desc_rel_all' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:312:6: warning: symbol 'iecm_rx_buf_rel_all' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:341:6: warning: symbol 'iecm_rx_desc_rel' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:371:6: warning: symbol 'iecm_rx_desc_rel_all' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:486:6: warning: symbol 'iecm_rx_hdr_buf_hw_alloc' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:564:47: warning: incorrect type in assignment (different base types)
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:564:47: expected restricted __le16 [usertype] buf_id
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:564:47: got restricted __le64 [usertype]
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:2072:50: warning: Using plain integer as NULL pointer
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:2319:27: warning: cast to restricted __le32
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:2319:27: warning: cast from restricted __le16
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:2852:23: warning: cast to restricted __le16
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3086:17: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3086:17: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3086:17: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3414:9: warning: incorrect type in argument 2 (different address spaces)
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3414:9: expected void volatile [noderef] <asn:2> *addr
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3414:9: got unsigned char [usertype] *
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3565:5: warning: symbol 'iecm_vport_splitq_napi_poll' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3603:6: warning: symbol 'iecm_vport_intr_map_vector_to_qs' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3715:5: warning: symbol 'iecm_vport_intr_alloc' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:1702:34: warning: incorrect type in assignment (different base types)
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:1702:34: expected unsigned char [usertype] cmd_dtype
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:1702:34: got restricted __le16 [usertype]
../drivers/net/ethernet/intel/iecm/iecm_virtchnl.c:12:6: warning: symbol 'iecm_recv_event_msg' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_virtchnl.c:61:1: warning: symbol 'iecm_mb_clean' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_main.c:17:5: warning: symbol 'debug' was not declared. Should it be static?
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:144: warning: Function parameter or member 'qinfo' not described in 'iecm_ctlq_add'
../drivers/net/ethernet/intel/iecm/iecm_controlq.c:144: warning: Excess function parameter 'q_info' description in 'iecm_ctlq_add'
In file included from ../include/linux/net/intel/iecm.h:50,
from ../drivers/net/ethernet/intel/iecm/iecm_osdep.c:5:
../include/linux/net/intel/iecm_txrx.h:293:30: warning: ‘iecm_rx_ptype_lkup’ defined but not used [-Wunused-const-variable=]
293 | struct iecm_rx_ptype_decoded iecm_rx_ptype_lkup[IECM_RX_SUPP_PTYPE] = {
| ^~~~~~~~~~~~~~~~~~
In file included from ../include/linux/net/intel/iecm.h:50,
from ../drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c:5:
../include/linux/net/intel/iecm_txrx.h:293:30: warning: ‘iecm_rx_ptype_lkup’ defined but not used [-Wunused-const-variable=]
293 | struct iecm_rx_ptype_decoded iecm_rx_ptype_lkup[IECM_RX_SUPP_PTYPE] = {
| ^~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c:584: warning: Function parameter or member 'rx_desc' not described in 'iecm_rx_singleq_process_skb_fields'
../drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c:584: warning: Function parameter or member 'ptype' not described in 'iecm_rx_singleq_process_skb_fields'
../drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c:645: warning: bad line:
../drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c:689: warning: Function parameter or member 'dev' not described in 'iecm_singleq_rx_get_buf_page'
../drivers/net/ethernet/intel/iecm/iecm_lib.c:49:13: warning: no previous prototype for ‘iecm_mb_intr_clean’ [-Wmissing-prototypes]
49 | irqreturn_t iecm_mb_intr_clean(int __always_unused irq, void *data)
| ^~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_lib.c:63:6: warning: no previous prototype for ‘iecm_mb_irq_enable’ [-Wmissing-prototypes]
63 | void iecm_mb_irq_enable(struct iecm_adapter *adapter)
| ^~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_lib.c:77:5: warning: no previous prototype for ‘iecm_mb_intr_req_irq’ [-Wmissing-prototypes]
77 | int iecm_mb_intr_req_irq(struct iecm_adapter *adapter)
| ^~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_lib.c:104:6: warning: no previous prototype for ‘iecm_get_mb_vec_id’ [-Wmissing-prototypes]
104 | void iecm_get_mb_vec_id(struct iecm_adapter *adapter)
| ^~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_lib.c:122:5: warning: no previous prototype for ‘iecm_mb_intr_init’ [-Wmissing-prototypes]
122 | int iecm_mb_intr_init(struct iecm_adapter *adapter)
| ^~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_lib.c:140:6: warning: no previous prototype for ‘iecm_intr_distribute’ [-Wmissing-prototypes]
140 | void iecm_intr_distribute(struct iecm_adapter *adapter)
| ^~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_lib.c:417:5: warning: no previous prototype for ‘iecm_vport_rel’ [-Wmissing-prototypes]
417 | int iecm_vport_rel(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_lib.c:748:6: warning: no previous prototype for ‘iecm_deinit_task’ [-Wmissing-prototypes]
748 | void iecm_deinit_task(struct iecm_adapter *adapter)
| ^~~~~~~~~~~~~~~~
In file included from ../include/linux/net/intel/iecm.h:50,
from ../drivers/net/ethernet/intel/iecm/iecm_lib.c:6:
../include/linux/net/intel/iecm_txrx.h:293:30: warning: ‘iecm_rx_ptype_lkup’ defined but not used [-Wunused-const-variable=]
293 | struct iecm_rx_ptype_decoded iecm_rx_ptype_lkup[IECM_RX_SUPP_PTYPE] = {
| ^~~~~~~~~~~~~~~~~~
In file included from ../include/linux/net/intel/iecm.h:50,
from ../drivers/net/ethernet/intel/iecm/iecm_ethtool.c:4:
../include/linux/net/intel/iecm_txrx.h:293:30: warning: ‘iecm_rx_ptype_lkup’ defined but not used [-Wunused-const-variable=]
293 | struct iecm_rx_ptype_decoded iecm_rx_ptype_lkup[IECM_RX_SUPP_PTYPE] = {
| ^~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_lib.c:490: warning: Function parameter or member 'vport_id' not described in 'iecm_vport_alloc'
../drivers/net/ethernet/intel/iecm/iecm_lib.c:490: warning: Excess function parameter 'vport_type' description in 'iecm_vport_alloc'
../drivers/net/ethernet/intel/iecm/iecm_ethtool.c:80: warning: Function parameter or member 'abs_rx_qid' not described in 'iecm_find_virtual_qid'
../drivers/net/ethernet/intel/iecm/iecm_ethtool.c:1031: warning: Function parameter or member 'cmd' not described in 'iecm_get_link_ksettings'
../drivers/net/ethernet/intel/iecm/iecm_ethtool.c:1031: warning: Excess function parameter 'ecmd' description in 'iecm_get_link_ksettings'
In file included from ../include/linux/net/intel/iecm.h:50,
from ../drivers/net/ethernet/intel/iecm/iecm_main.c:6:
../include/linux/net/intel/iecm_txrx.h:293:30: warning: ‘iecm_rx_ptype_lkup’ defined but not used [-Wunused-const-variable=]
293 | struct iecm_rx_ptype_decoded iecm_rx_ptype_lkup[IECM_RX_SUPP_PTYPE] = {
| ^~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_virtchnl.c:12:6: warning: no previous prototype for ‘iecm_recv_event_msg’ [-Wmissing-prototypes]
12 | void iecm_recv_event_msg(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_virtchnl.c:61:1: warning: no previous prototype for ‘iecm_mb_clean’ [-Wmissing-prototypes]
61 | iecm_mb_clean(struct iecm_adapter *adapter)
| ^~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_virtchnl.c:1422: warning: Function parameter or member 'vport' not described in 'iecm_send_get_stats_msg'
../drivers/net/ethernet/intel/iecm/iecm_virtchnl.c:1422: warning: Excess function parameter 'adapter' description in 'iecm_send_get_stats_msg'
../drivers/net/ethernet/intel/iecm/iecm_virtchnl.c:1701: warning: Function parameter or member 'hw' not described in 'iecm_find_ctlq'
../drivers/net/ethernet/intel/iecm/iecm_virtchnl.c:1701: warning: Excess function parameter 'adapter' description in 'iecm_find_ctlq'
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:84:6: warning: no previous prototype for ‘iecm_tx_buf_rel_all’ [-Wmissing-prototypes]
84 | void iecm_tx_buf_rel_all(struct iecm_queue *txq)
| ^~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:115:6: warning: no previous prototype for ‘iecm_tx_desc_rel’ [-Wmissing-prototypes]
115 | void iecm_tx_desc_rel(struct iecm_queue *txq, bool bufq)
| ^~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:136:6: warning: no previous prototype for ‘iecm_tx_desc_rel_all’ [-Wmissing-prototypes]
136 | void iecm_tx_desc_rel_all(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:312:6: warning: no previous prototype for ‘iecm_rx_buf_rel_all’ [-Wmissing-prototypes]
312 | void iecm_rx_buf_rel_all(struct iecm_queue *rxq)
| ^~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:341:6: warning: no previous prototype for ‘iecm_rx_desc_rel’ [-Wmissing-prototypes]
341 | void iecm_rx_desc_rel(struct iecm_queue *rxq, bool bufq,
| ^~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:371:6: warning: no previous prototype for ‘iecm_rx_desc_rel_all’ [-Wmissing-prototypes]
371 | void iecm_rx_desc_rel_all(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:486:6: warning: no previous prototype for ‘iecm_rx_hdr_buf_hw_alloc’ [-Wmissing-prototypes]
486 | bool iecm_rx_hdr_buf_hw_alloc(struct iecm_queue *rxq,
| ^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3565:5: warning: no previous prototype for ‘iecm_vport_splitq_napi_poll’ [-Wmissing-prototypes]
3565 | int iecm_vport_splitq_napi_poll(struct napi_struct *napi, int budget)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3603:6: warning: no previous prototype for ‘iecm_vport_intr_map_vector_to_qs’ [-Wmissing-prototypes]
3603 | void iecm_vport_intr_map_vector_to_qs(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3715:5: warning: no previous prototype for ‘iecm_vport_intr_alloc’ [-Wmissing-prototypes]
3715 | int iecm_vport_intr_alloc(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~~~
In file included from ../include/linux/net/intel/iecm.h:50,
from ../drivers/net/ethernet/intel/iecm/iecm_txrx.c:4:
../include/linux/net/intel/iecm_txrx.h:293:30: warning: ‘iecm_rx_ptype_lkup’ defined but not used [-Wunused-const-variable=]
293 | struct iecm_rx_ptype_decoded iecm_rx_ptype_lkup[IECM_RX_SUPP_PTYPE] = {
| ^~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:2593: warning: Function parameter or member 'dev' not described in 'iecm_rx_get_buf_page'
../drivers/net/ethernet/intel/iecm/iecm_txrx.c:3841: warning: Function parameter or member 'qid_list' not described in 'iecm_get_rx_qid_list'
Powered by blists - more mailing lists