lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 17 Jun 2020 17:02:29 -0700
From:   Jakub Kicinski <>
To:     Eric Dumazet <>
Cc:     "David S . Miller" <>,
        netdev <>,
        Eric Dumazet <>,
        Willem de Bruijn <>,
        Antoine Tenart <>
Subject: Re: [PATCH net-next 1/5] net: tso: double TSO_HEADER_SIZE value

On Wed, 17 Jun 2020 11:48:15 -0700 Eric Dumazet wrote:
> Transport header size could be 60 bytes, and network header
> size can also be 60 bytes. Add the Ethernet header and we
> are above 128 bytes.
> Since drivers using net/core/tso.c usually allocates
> one DMA coherent piece of memory per TX queue, this patch
> might cause issues if a driver was using too many slots.
> For 1024 slots, we would need 256 KB of physically
> contiguous memory instead of 128 KB.
> Alternative fix would be to add checks in the fast path,
> but this involves more work in all drivers using net/core/tso.c.
> Fixes: f9cbe9a556af ("net: define the TSO header size in net/tso.h")
> Signed-off-by: Eric Dumazet <>
> Cc: Antoine Tenart <>

Some warnings popping up in this series with W=1 C=1:

drivers/net/ethernet/marvell/octeontx2/af/common.h:65:26: warning: cast truncates bits from constant value (100 becomes 0)

Powered by blists - more mailing lists