lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Jun 2020 14:02:03 -0700 From: Alexei Starovoitov <alexei.starovoitov@...il.com> To: Maciej Żenczykowski <zenczykowski@...il.com> Cc: Maciej Żenczykowski <maze@...gle.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Linux Network Development Mailing List <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, BPF Mailing List <bpf@...r.kernel.org>, "David S . Miller" <davem@...emloft.net> Subject: Re: [PATCH] restore behaviour of CAP_SYS_ADMIN allowing the loading of net bpf program On Thu, Jun 18, 2020 at 1:00 PM Maciej Żenczykowski <zenczykowski@...il.com> wrote: > > From: Maciej Żenczykowski <maze@...gle.com> > > This is a 5.8-rc1 regression. Please add full explanation here. Also use [PATCH bpf] in the subject for future submission. > Cc: Alexei Starovoitov <ast@...nel.org> > Cc: Daniel Borkmann <daniel@...earbox.net> > Fixes: 2c78ee898d8f ("bpf: Implement CAP_BPF") Reported-by: John is missing? > Signed-off-by: Maciej Żenczykowski <maze@...gle.com> > --- > kernel/bpf/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c > index 8da159936bab..7d946435587d 100644 > --- a/kernel/bpf/syscall.c > +++ b/kernel/bpf/syscall.c > @@ -2121,7 +2121,7 @@ static int bpf_prog_load(union bpf_attr *attr, union bpf_attr __user *uattr) > !bpf_capable()) > return -EPERM; > > - if (is_net_admin_prog_type(type) && !capable(CAP_NET_ADMIN)) > + if (is_net_admin_prog_type(type) && !capable(CAP_NET_ADMIN) && !capable(CAP_SYS_ADMIN)) > return -EPERM; > if (is_perfmon_prog_type(type) && !perfmon_capable()) > return -EPERM; > -- > 2.27.0.290.gba653c62da-goog >
Powered by blists - more mailing lists