netdev - Re: [PATCH bpf-next v4 3/3] bpf: add SO_KEEPALIVE and related options to bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jun 2020 14:33:07 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Dmitry Yakunin <zeil@...dex-team.ru>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Lawrence Brakmo <brakmo@...com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Martin KaFai Lau <kafai@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next v4 3/3] bpf: add SO_KEEPALIVE and related options
 to bpf_setsockopt

On Wed, Jun 17, 2020 at 4:02 AM Dmitry Yakunin <zeil@...dex-team.ru> wrote:
>
> This patch adds support of SO_KEEPALIVE flag and TCP related options
> to bpf_setsockopt() routine. This is helpful if we want to enable or tune
> TCP keepalive for applications which don't do it in the userspace code.
>
> v2:
>   - update kernel-doc (Nikita Vetoshkin <nekto0n@...dex-team.ru>)
>
> Signed-off-by: Dmitry Yakunin <zeil@...dex-team.ru>
> Acked-by: Martin KaFai Lau <kafai@...com>
> ---
>  include/uapi/linux/bpf.h |  7 +++++--
>  net/core/filter.c        | 36 +++++++++++++++++++++++++++++++++++-
>  2 files changed, 40 insertions(+), 3 deletions(-)

Please update tools/include/uapi/linux/bpf.h as well.

Also please add a selftest for at least some new opts.