netdev - Re: [net-next PATCH 2/5 v2] net: dsa: rtl8366rb: Support the CPU DSA tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jun 2020 03:27:55 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, DENG Qingfang <dqfext@...il.com>,
        Mauri Sandberg <sandberg@...lfence.com>
Subject: Re: [net-next PATCH 2/5 v2] net: dsa: rtl8366rb: Support the CPU DSA
 tag

On Wed, Jun 17, 2020 at 10:31:29AM +0200, Linus Walleij wrote:
> This activates the support to use the CPU tag to properly
> direct ingress traffic to the right port.
> 
> Bit 15 in register RTL8368RB_CPU_CTRL_REG can be set to
> 1 to disable the insertion of the CPU tag which is what
> the code currently does. The bit 15 define calls this
> setting RTL8368RB_CPU_INSTAG which is confusing since the
> iverse meaning is implied: programmers may think that

inverse

> setting this bit to 1 will *enable* inserting the tag
> rather than disablinbg it, so rename this setting in

disabling

> bit 15 to RTL8368RB_CPU_NO_TAG which is more to the
> point.
> 
> After this e.g. ping works out-of-the-box with the
> RTL8366RB.
> 
> Cc: DENG Qingfang <dqfext@...il.com>
> Cc: Mauri Sandberg <sandberg@...lfence.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew