netdev - Re: af_decnet.c: missing semi-colon and/or indentation?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <407fa160-aec6-3135-1579-f833bebe59a2@gmail.com>
Date:   Thu, 18 Jun 2020 16:35:38 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: af_decnet.c: missing semi-colon and/or indentation?



On 6/18/20 4:19 PM, Randy Dunlap wrote:
> 
> Please see lines 1250-1251.
> 
> 
> 	case TIOCINQ:
> 		lock_sock(sk);
> 		skb = skb_peek(&scp->other_receive_queue);
> 		if (skb) {
> 			amount = skb->len;
> 		} else {
> 			skb_queue_walk(&sk->sk_receive_queue, skb)     <<<<<
> 				amount += skb->len;                    <<<<<
> 		}
> 		release_sock(sk);
> 		err = put_user(amount, (int __user *)arg);
> 		break;
> 
> 
> 
> or is this some kind of GCC nested function magic?
> 

I do not see a problem

for (bla; bla; bla)
        amount += skb->len;

Seems good to me.

> 
> commit bec571ec762a4cf855ad4446f833086fc154b60e
> Author: David S. Miller <davem@...emloft.net>
> Date:   Thu May 28 16:43:52 2009 -0700
> 
>     decnet: Use SKB queue and list helpers instead of doing it by-hand.
> 
> 
> 
> thanks.
> 

Also decnet should not be any of our concerns in 2020 ?