netdev - Re: [PATCH net-next v8 2/5] net: phy: Add a helper to return the index for of the internal delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jun 2020 18:42:23 -0500
From:   Dan Murphy <dmurphy@...com>
To:     kernel test robot <lkp@...el.com>, <andrew@...n.ch>,
        <f.fainelli@...il.com>, <hkallweit1@...il.com>,
        <davem@...emloft.net>, <robh@...nel.org>
CC:     <kbuild-all@...ts.01.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH net-next v8 2/5] net: phy: Add a helper to return the
 index for of the internal delay

Hello

On 6/18/20 6:29 PM, kernel test robot wrote:
> Hi Dan,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on net-next/master]
>
> url:    https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200619-051238
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2
> config: i386-defconfig (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
> reproduce (this is a W=1 build):
>          # save the attached .config to linux build tree
>          make W=1 ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All errors (new ones prefixed by >>):
>
>     drivers/net/phy/phy_device.c: In function 'phy_get_int_delay_property':
>>> drivers/net/phy/phy_device.c:2678:1: error: expected ';' before '}' token
>      2678 | }
>           | ^
>
> vim +2678 drivers/net/phy/phy_device.c
>
>    2660	
>    2661	#if IS_ENABLED(CONFIG_OF_MDIO)
>    2662	static int phy_get_int_delay_property(struct device *dev, const char *name)
>    2663	{
>    2664		s32 int_delay;
>    2665		int ret;
>    2666	
>    2667		ret = device_property_read_u32(dev, name, &int_delay);
>    2668		if (ret)
>    2669			return ret;
>    2670	
>    2671		return int_delay;
>    2672	}
>    2673	#else
>    2674	static inline int phy_get_int_delay_property(struct device *dev,
>    2675						     const char *name)
>    2676	{
>    2677		return -EINVAL

Ack missed compiling this use case.

Dan

>> 2678	}
>    2679	#endif
>    2680	
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org