netdev - Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jun 2020 20:35:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     drc@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, siva.kallam@...adcom.com,
        prashant@...adcom.com, mchan@...adcom.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors
 exceed eeh_max_freezes

From: David Christensen <drc@...ux.vnet.ibm.com>
Date: Wed, 17 Jun 2020 11:51:17 -0700

> The driver function tg3_io_error_detected() calls napi_disable twice,
> without an intervening napi_enable, when the number of EEH errors exceeds
> eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock.
> 
> Add check for pcierr_recovery which skips code already executed for the
> "Frozen" state.
> 
> Signed-off-by: David Christensen <drc@...ux.vnet.ibm.com>

Applied and queued up for -stable, thanks.