netdev - Re: [PATCHv2 net] tc-testing: update geneve options match in tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jun 2020 10:02:30 +0200
From:   Davide Caratti <dcaratti@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Lucas Bates <lucasb@...atatu.com>,
        Simon Horman <simon.horman@...ronome.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCHv2 net] tc-testing: update geneve options match in
 tunnel_key unit tests

thanks for the patch,

On Fri, 2020-06-19 at 11:24 +0800, Hangbin Liu wrote:
> Since iproute2 commit f72c3ad00f3b ("tc: m_tunnel_key: add options
> support for vxlan"), the geneve opt output use key word "geneve_opts"
> instead of "geneve_opt". To make compatibility for both old and new
> iproute2, let's accept both "geneve_opt" and "geneve_opts".
> 
> Suggested-by: Davide Caratti <dcaratti@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  .../tc-testing/tc-tests/actions/tunnel_key.json    | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

it has been successfully verified with the following command:

# for t in 4f20 e33d 0778 4ae8 4039 26a6 f44d ; do ./tdc.py -e $t ; done

using two tc binaries, one compiled from f72c3ad00f3b^ and the other one
from HEAD. I would have liked to see a list of OK with this command:

# ./tdc.cy -c tunnel_key

but (at least on my test setup) I see a failure here:

# ./tdc.py  -e 364d
Test 364d: Replace tunnel_key set action with all parameters and cookie

-----> prepare stage *** Could not execute: "$TC actions add action tunnel_key set src_ip 10.10.10.1 dst_ip 20.20.20.2 dst_port 3128 nocsum id 1 index 1 cooki
e aabbccddeeff112233445566778800a"

-----> prepare stage *** Error message: "Error: argument "aabbccddeeff112233445566778800a" is wrong: cookie must be a hex string

"                                      
returncode 255; expected [0]

-----> prepare stage *** Aborting test run.


<_io.BufferedReader name=3> *** stdout ***


<_io.BufferedReader name=5> *** stderr ***
"-----> prepare stage" did not complete successfully
Exception <class '__main__.PluginMgrTestFail'> ('setup', None, '"-----> prepare stage" did not complete successfully') (caught in test_runner, running test 2 
364d Replace tunnel_key set action with all parameters and cookie stage setup)
---------------                        
traceback                              
  File "./tdc.py", line 371, in test_runner
    res = run_one_test(pm, args, index, tidx)
  File "./tdc.py", line 272, in run_one_test
    prepare_env(args, pm, 'setup', "-----> prepare stage", tidx["setup"])
  File "./tdc.py", line 245, in prepare_env
    raise PluginMgrTestFail(
---------------                        
---------------                        

All test results:                      

1..1                                   
ok 1 364d - Replace tunnel_key set action with all parameters and cookie # skipped - "-----> prepare stage" did not complete successfully

I checked twice, and the problem only happens with the new iproute2 binary.
So, there seems to be an additional tdc breakage in the latest iproute2.
But the problem looks unrelated to your patch, and I follow-up in the next hours.

Tested-by: Davide Caratti <dcaratti@...hat.com>