netdev - Re: [PATCH net] enetc: Fix HW_VLAN_CTAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Jun 2020 20:01:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     claudiu.manoil@....com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] enetc: Fix HW_VLAN_CTAG_TX|RX toggling

From: Claudiu Manoil <claudiu.manoil@....com>
Date: Thu, 18 Jun 2020 12:16:52 +0300

> VLAN tag insertion/extraction offload is correctly
> activated at probe time but deactivation of this feature
> (i.e. via ethtool) is broken.  Toggling works only for
> Tx/Rx ring 0 of a PF, and is ignored for the other rings,
> including the VF rings.
> To fix this, the existing VLAN offload toggling code
> was extended to all the rings assigned to a netdevice,
> instead of the default ring 0 (likely a leftover from the
> early validation days of this feature).  And the code was
> moved to the common set_features() function to fix toggling
> for the VF driver too.
> 
> Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers")
> Signed-off-by: Claudiu Manoil <claudiu.manoil@....com>

Applied and queued up for -stable, thanks.