netdev - Re: [PATCH -next] macvlan: Fix memleak in macvlan_changelink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200619.201504.540882827677086606.davem@davemloft.net>
Date:   Fri, 19 Jun 2020 20:15:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhengbin13@...wei.com
Cc:     kuba@...nel.org, michael-dev@...i-braun.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com
Subject: Re: [PATCH -next] macvlan: Fix memleak in
 macvlan_changelink_sources

From: Zheng Bin <zhengbin13@...wei.com>
Date: Thu, 18 Jun 2020 21:26:29 +0800

> macvlan_changelink_sources
>   if (addr)
>     ret = macvlan_hash_add_source(vlan, addr)
>   nla_for_each_attr(nla, head, len, rem)
>     ret = macvlan_hash_add_source(vlan, addr)
>     -->If fail, need to free previous malloc memory
> 
> Fixes: 79cf79abce71 ("macvlan: add source mode")
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>

Bug fixes should never be submitted against net-next.

They should instead be submitted against 'net'.

Thank you.