netdev - Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200619.202058.334256505365421992.davem@davemloft.net>
Date:   Fri, 19 Jun 2020 20:20:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     antoine.tenart@...tlin.com, alexandre.belloni@...tlin.com,
        kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port()
 helper

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Thu, 18 Jun 2020 16:38:51 +0100

> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 7653277d03b7..8c8314715efd 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -4767,12 +4767,17 @@ static void mvpp2_port_copy_mac_addr(struct net_device *dev, struct mvpp2 *priv,
>  	eth_hw_addr_random(dev);
>  }
>  
> +static inline struct mvpp2_port *
> +mvpp2_phylink_to_port(struct phylink_config *config)
> +{
> +	return container_of(config, struct mvpp2_port, phylink_config);
> +}

Please don't use inline in foo.c files, thank you.